Check for invalid symbol names in llvm-nm output. #17888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
nm_output_check
branch
from
36379bd
to
b811b47
Compare
sbc100
force-pushed
the
nm_output_check
branch
from
b811b47
to
6a67774
Compare
kripken
reviewed
Sep 19, 2022
|
lgtm, feel free to ignore comment suggestion if you prefer it shorter. |
Co-authored-by: Alon Zakai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12551 and:
#17826
Older versions of llvm didn't used to mangle these __invoke symbols.